js feat: Support attachments in traceable #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add warning & handling of invalid attachments. Proposed API: getAttachments(args) => [attachments, otherArgs]; Returning the filtered args means that you're less likely to accidentally double-log attachments in inputs.
hinthornw
force-pushed
the
wfh/attachments_js
branch
from
2000191 to
a4b3879
Compare
dqbd
reviewed
Nov 5, 2024
dqbd
reviewed
Nov 5, 2024
hinthornw
force-pushed
the
wfh/attachments_js
branch
from
72e342e to
0c39fc1
Compare
hinthornw
force-pushed
the
wfh/attachments_js
branch
from
0c39fc1 to
d707b54
Compare
agola11
reviewed
Nov 5, 2024
agola11
approved these changes
Nov 5, 2024
hinthornw
force-pushed
the
wfh/attachments_js
branch
from
062e4c9 to
c868311
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add warning & handling of invalid attachments.
Proposed API:
getAttachments(args) => [attachments, otherArgs];
Returning the filtered args means that you're less likely to accidentally double-log attachments in inputs.